Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Add OCI controller implemented with oracle API code. #2526

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DRAFT: Add OCI controller implemented with oracle API code. #2526

wants to merge 1 commit into from

Conversation

bkopilov
Copy link
Contributor

@bkopilov bkopilov commented Sep 7, 2024

This patch allow us decouple terraform code from cluster testing. Terraform provided by oracle and maintained by them. Terraform version / code may be updated by oracle .

We run the test same as customer , created support for the next steps:

  1. Create a bucket (object-storage)
  2. Upload ISO file to the object-storage bucket
  3. Create pre authenticated - return ISO download link from OCI storage
  4. Create a stack , declare the provision configuration.
  5. Upload infrastructure zip file to the stack and set terraform variable
  6. Start running job creating oci nodes discovered by redhat cluster and return terraform output files
  7. Once nodes are discovered we configure manifest return in README fixes #6

We handle cleanup on teardown , running destory .

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkopilov
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 7, 2024

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bkopilov bkopilov changed the title Add OCI controller implemented with oracle API code. DRAFT: Add OCI controller implemented with oracle API code. Sep 7, 2024
@bkopilov
Copy link
Contributor Author

bkopilov commented Sep 7, 2024

@adriengentil , @mburman5 , @talhil-rh , @eifrach , @AlonaKaplan

@bkopilov
Copy link
Contributor Author

bkopilov commented Sep 7, 2024

POC code , need to add terraform.zip support (download) ...

@bkopilov
Add OCI controller implemented with oracle API code.
d20030c 
This patch allow us decouple terraform code from cluster testing.
Terraform provided by oracle and maintained by them.
Terraform version / code may be updated by oracle .

We run the test same as customer , created support for the next steps:
1. Create a bucket (object-storage)
2. Upload ISO file to the object-storage bucket
3. Create pre authenticated - return ISO download link from OCI storage
4. Create a stack , declare the provision configuration.
5. Upload infrastructure zip file to the stack and set terraform variable
6. Start running job creating oci nodes discovered by redhat cluster and return terraform output files
7. Once nodes are discovered we configure manifest return in openshift#6

We handle cleanup on teardown , running destory .
@adriengentil
Copy link
Contributor

/ok-to-test
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2024
@bkopilov
Copy link
Contributor Author

I dont think it will work ... need to tune the terraform zip file before.
Maybe we can start review in steps till we have full picture and proper configuration

@adriengentil adriengentil marked this pull request as draft September 12, 2024 07:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@adriengentil
Copy link
Contributor

I dont think it will work ... need to tune the terraform zip file before. Maybe we can start review in steps till we have full picture and proper configuration

I set the PR as draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorerz eliorerz Awaiting requested review from eliorerz

@omertuc omertuc Awaiting requested review from omertuc

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkopilov @adriengentil